[
https://issues.apache.org/jira/browse/AVRO-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187827#comment-13187827
]
Doug Cutting commented on AVRO-994:
-----------------------------------
Two small things:
1. Please put the name(s) of the patch author(s) and committer in CHANGES.txt.
2. Since 1.6.2 will be released before 1.7.0, there's no need to note this as
fixed in 1.7.0.
Other than that, great job and thanks!
> TestFileSpanStorage.testTonsOfSpans() fails on my slow VM
> ---------------------------------------------------------
>
> Key: AVRO-994
> URL: https://issues.apache.org/jira/browse/AVRO-994
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.6.0, 1.6.1
> Reporter: James Baldassari
> Assignee: James Baldassari
> Priority: Minor
> Fix For: 1.6.2, 1.7.0
>
> Attachments: AVRO-994.patch
>
>
> {noformat}
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 15.554 sec
> <<< FAILURE!
> testTonsOfSpans(org.apache.avro.ipc.trace.TestFileSpanStorage) Time elapsed:
> 3.853 sec <<< FAILURE!
> java.lang.AssertionError: expected:<50000> but was:<42356>
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.failNotEquals(Assert.java:647)
> at org.junit.Assert.assertEquals(Assert.java:128)
> at org.junit.Assert.assertEquals(Assert.java:472)
> at org.junit.Assert.assertEquals(Assert.java:456)
> at
> org.apache.avro.ipc.trace.TestFileSpanStorage.testTonsOfSpans(TestFileSpanStorage.java:70)
> {noformat}
> The issue seems to be the {{Thread.sleep(2000)}} on line 66. Doubling this
> to 4000ms causes the test to pass. In general it might be better to make
> this sleep event-based rather than using a fixed sleep time. If that isn't
> possible, then maybe using some sort of a retry loop would work.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
