[ 
https://issues.apache.org/jira/browse/AVRO-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194784#comment-13194784
 ] 

Craig Landry commented on AVRO-1005:
------------------------------------

The revised patch works fine for me, but I think it may change the expected 
default behavior for others.  

Currently (avro 1.6.1) if an HttpTranceiver is created with only the url 
argument (no Proxy provided) the url connection will respect the http.proxyHost 
system property if set.  The modified patch will set the proxy to the static 
NO_PROXY in this case though, which will will cause the http.proxyHost property 
to be ignored.  Users using the HttpTranceiver class with the single-argment 
constructor and a http.proxyHost system property will find that the property is 
ignored when previously it was not.

For backwards compatibility/consistency, it may be better to use the URL class' 
different constructors as seen in the original patch.
                
> Add optional parameter to HttpTransceiver for Proxy
> ---------------------------------------------------
>
>                 Key: AVRO-1005
>                 URL: https://issues.apache.org/jira/browse/AVRO-1005
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.6.1
>            Reporter: Craig Landry
>            Assignee: Craig Landry
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.6.2
>
>         Attachments: AVRO-1005.patch, optional_proxy_for_url_connection.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to