[
https://issues.apache.org/jira/browse/AVRO-973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcio Silva updated AVRO-973:
------------------------------
Labels: patch (was: )
Affects Version/s: 1.6.2
1.6.1
Status: Patch Available (was: Open)
Attached is a patch that addresses this issue. At root, the
current python implementation doesn't always enforce strict types for numeric
data.
The union resolution code chooses the first type that's valid for the given
input, and the current validate logic allows int values in long fields etc.
> Union behavior not consistent
> -----------------------------
>
> Key: AVRO-973
> URL: https://issues.apache.org/jira/browse/AVRO-973
> Project: Avro
> Issue Type: Bug
> Components: python
> Affects Versions: 1.6.1, 1.6.2
> Reporter: Gaurav Nanda
> Labels: patch
> Attachments: test_unions.py
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Python's union does not respect the order in which type is specified.
> For following schema:
> {"type":"map","values":["int","long","float","double","string","boolean"]},
> an integer value is written as double, but it should respect the order in
> which types have been specified.
> Fixed Code (io.py):
> def write_union(self, writers_schema, datum, encoder):
> """
> A union is encoded by first writing a long value indicating
> the zero-based position within the union of the schema of its value.
> The value is then encoded per the indicated schema within the union.
> """
> # resolve union
> index_of_schema = -1
> for i, candidate_schema in enumerate(writers_schema.schemas):
> if validate(candidate_schema, datum):
> index_of_schema = i
> break // XXX Add break statement here XXX//
> if index_of_schema < 0: raise AvroTypeException(writers_schema, datum)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
