[
https://issues.apache.org/jira/browse/AVRO-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliott Clark updated AVRO-1024:
--------------------------------
Attachment: AVRO-1024-2.patch
Here's another go at it with Doug's suggestions.
I added getters, javadocs, and tests. In adding tests I moved the JsonEncoder
tests to their own file.
> Allow users to subclass JsonEncoder
> -----------------------------------
>
> Key: AVRO-1024
> URL: https://issues.apache.org/jira/browse/AVRO-1024
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.5.4
> Reporter: Elliott Clark
> Attachments: AVRO-1024-1.patch, AVRO-1024-2.patch
>
>
> Users who want to use a different representation of json from the JsonEncoder
> are forced to re-implement all of it since JsonEncoder's internals are all
> private. For example I wanted to make the json not contain type hints for
> unions. That required only overriding one method after this fix.
> To fix this making things protected will allow users to change just code that
> is needed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
