[
https://issues.apache.org/jira/browse/AVRO-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204229#comment-13204229
]
Harsh J commented on AVRO-300:
------------------------------
+1, just went over this and the patch looks good.
Btw, found one nit you can fix during commit:
{code}
class Field(object):
- def __init__(self, type, name, has_default, default=None, order=None,
names=None):
+ def __init__(self, type, name, has_default, default=None,
order=None,names=None, doc=None):
{code}
There is a missing space before 'names'.
> Support "doc" field in schemas in Python implementation
> -------------------------------------------------------
>
> Key: AVRO-300
> URL: https://issues.apache.org/jira/browse/AVRO-300
> Project: Avro
> Issue Type: New Feature
> Components: python
> Reporter: Jeff Hammerbacher
> Assignee: Marcio Silva
> Fix For: 1.6.2
>
> Attachments: AVRO-300-patch-1.patch, AVRO-300-patch-1.patch
>
>
> AVRO-152 adds a "doc" field to Record and Enum schemas in the Java
> implementation. We should do the same for the Python implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
