[ 
https://issues.apache.org/jira/browse/AVRO-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214932#comment-13214932
 ] 

Doug Cutting commented on AVRO-1006:
------------------------------------

This looks generally good.  A few nits:
 - In class and method names, should we abbreviate 'fp' or spell out 
'fingerprint'?  FP means "floating point" to my eye.
 - Might we instead put this in org.apache.avro.SchemaFingerprint, rather than 
in util?  Right now things in the util package depend only on the JDK, not on 
other parts of Avro.
 - Public methods and classes need javadoc comments.
 - The changes to the spec are not correctly processed by Forrest 0.8 for me.
                
> Fingerprints for Avro Schemas
> -----------------------------
>
>                 Key: AVRO-1006
>                 URL: https://issues.apache.org/jira/browse/AVRO-1006
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Raymie Stata
>            Assignee: Raymie Stata
>              Labels: features
>         Attachments: AVRO-1006-prelim.patch, AVRO-1006.patch, 
> schema-fingerprinting.html, schema-fingerprinting.html, 
> schema-fingerprinting.html
>
>
> Add function that returns a standardized, 64-bit fingerprint for schemas.  
> Fingerprints are designed such that the chances of collisions is very, very 
> low.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to