[
https://issues.apache.org/jira/browse/AVRO-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Douglas Creager updated AVRO-1039:
----------------------------------
Attachment: 0001-AVRO-1039.-C-Don-t-try-to-use-nonexistent-codecs-in-.patch
The null codec is always present, so we can fall back on that if we didn't
build the deflate codec. And we've already got preprocessor macros that we can
check to see whether each particular codec is present.
> Avro-C: Test 1 (quickstop) requires deflate codec, and fails when it is
> missing
> -------------------------------------------------------------------------------
>
> Key: AVRO-1039
> URL: https://issues.apache.org/jira/browse/AVRO-1039
> Project: Avro
> Issue Type: Bug
> Components: c
> Affects Versions: 1.6.2
> Environment: GNU/Linux Ubuntu 11.10 64-bit
> Reporter: Vivek Nadkarni
> Priority: Minor
> Fix For: 1.6.3
>
> Attachments:
> 0001-AVRO-1039.-C-Don-t-try-to-use-nonexistent-codecs-in-.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> Summary:
> The test/example quickstop requires the deflate codec. However, the deflate
> codec is an optional codec, and not a requirement for Avro-C. So the tests
> should pass even when the deflate codec is unavailable.
> Not sure of the best way to test features dependent on optional libraries,
> and (a) pass the tests when the optional libraries are not available, but (b)
> fail the tests when the libraries are available, but the code doesn't work
> properly.
> Details:
> When I make Avro-C using the following commands from the avro-trunk/lang/c
> directory:
> mkdir -p build
> cd build
> cmake .. -DCMAKE_INSTALL_PREFIX=avrolib -DCMAKE_BUILD_TYPE=Debug
> make
> make test
> make install
> I get the following messages (as expected, since I don't have the libs):
> <snip>
> -- Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR)
> Disabled deflate codec. zlib not found.
> -- checking for module 'liblzma'
> -- package 'liblzma' not found
> Disabled lzma codec. liblzma not found.
> <snip>
> But then, during the tests, I get the error:
> 1/10 Test #1: quickstop ........................***Failed 0.00 sec
> And, when I run quickstop manually:
> ~/avro-trunk/lang/c/build/examples$ ./quickstop
> There was an error creating quickstop.db
> error message: Unknown codec deflate
> Cheers,
> Vivek
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
