[
https://issues.apache.org/jira/browse/AVRO-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224212#comment-13224212
]
Lars Francke commented on AVRO-987:
-----------------------------------
Looks good - I applied and tested it briefly.
I have just a few small comments:
* {{lang/java/pom.xml}} has {{bundle-plugin-version}} but a recent patch
changed the convention to use dots. So it'd be {{bundle-plugin.version}} now
* {{ClassLoadingUtils.loadClass(String className)}} calls the qualified
{{ClassLoadingUtils.loadClass}} while the other methods are using the
unqualified {{loadClass}} version
* {{ClassLoadingUtils.loadClass(ClassLoader classLoader, String className)}} is
not used as far as I can tell
* Javadoc for the private {{loadClass(String className, ClassLoader
classLoader)}} has wrong {{{@ClassNotFoundException}}} tag. Missing the
{{link}} part. Also empty parameter and return tags.
> Make Avro OSGi ready
> --------------------
>
> Key: AVRO-987
> URL: https://issues.apache.org/jira/browse/AVRO-987
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Ioannis Canellos
> Attachments: AVRO-987-1_6_3-patch.txt, AVRO-987-patch-updated.txt,
> AVRO-987-patch.txt
>
>
> It would be really nice to be able to use Avro inside OSGi. To achieve this
> two things are required:
> i) Provide proper MANIFEST.MF.
> ii) Deal with potential class loading issues. Avro uses Class.forName a lot
> and that is not very OSGi friendly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
