OK, it's ready. Will commit tomorrow afternoon.
On Wed, Mar 14, 2012 at 2:53 PM, Scott Carey <[email protected]> wrote: > > On 3/14/12 1:31 PM, "Miki Tebeka" <[email protected]> wrote: > >>Yeah, my bad sorry. (had the patch applied twice). >>Tests pass, should I commit? > > > In addition to Doug's comments, make sure you add the appropriate line to > CHANGES.txt when you commit. Follow the conventions in there, listing the > JIRA ticket and noting the contributor. > >
