[
https://issues.apache.org/jira/browse/AVRO-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261729#comment-13261729
]
Douglas Creager commented on AVRO-551:
--------------------------------------
All tests pass for me on Visual Studio 2010 Premium. I don't have objections
to anything in the patch. The only thing that might be controversial, from
what I can see, is that since we're compiling using VC++ under Windows, we have
to include many more pointer casts. In particular, we have to cast the result
of all of our malloc-like calls, since C++ doesn't automatically cast from
{{void *}}. In C, the best practice is to not include a cast, so that the
compiler can yell at you if you forgot to include the header file that defines
malloc. I think that since we're using avro_malloc and friends, rather than
the system malloc, this is not an issue that we have to worry about.
So, short version, +1. If I don't hear any objections from Bruce or others by
Friday, I'll commit this is SVN.
> C: Build and pass tests on Win32
> --------------------------------
>
> Key: AVRO-551
> URL: https://issues.apache.org/jira/browse/AVRO-551
> Project: Avro
> Issue Type: Improvement
> Components: c
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Bruce Mitchener
> Attachments: AVRO-551-license.patch, AVRO-551-patch2.patch,
> AVRO-551.patch
>
>
> Avro C does not currently build on Win32. We need to address that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
