[ 
https://issues.apache.org/jira/browse/AVRO-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270693#comment-13270693
 ] 

David Taylor commented on AVRO-975:
-----------------------------------

Thank you for this patch, I was able to apply it to 1.6.3 with Cygwin without 
problems.  There are a few issues that I ran into with the patch:
1. The error specification is not handled correctly as it does not include the 
default "string" schema for unlisted errors.
2. Type.Error is not uniformly supported.
3. Requestor does not resend after a failed handshake.
4. Requestor handshake logic assumes that all transceivers maintain connection 
state.
5. Generic messages cannot be sent as Requestor uses SpecificWriter for 
serializing the request.

I was able to patch for items 1-3 with minimal changes.  For items 4 & 5 I was 
able to patch for my specific use case but would require more work for a 
general fix.  I can send you my changes if you like. 
                
> Support RPC in C#
> -----------------
>
>                 Key: AVRO-975
>                 URL: https://issues.apache.org/jira/browse/AVRO-975
>             Project: Avro
>          Issue Type: New Feature
>          Components: csharp
>    Affects Versions: 1.6.1
>            Reporter: Jeff Hammerbacher
>         Attachments: 975.patch, buildtask.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to