[
https://issues.apache.org/jira/browse/AVRO-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. updated AVRO-1079:
--------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed revision 1339055 after testing it on:
- Windows 7 (Visual C++ Express 2010)
- Cygwin on Windows 7
- Ubuntu 12.04
Thank you Falk Trinstram for the suggestion. I think this should take care your
version control issue. I don't think it can take care your problem with make
because make only looks at the timestamp but not the contents of the header
file generated. It will be hard for the code generator to examine the contents
of the header file and decide whether to generate afresh or not. One solution
is to generate the contents in memory and then compare it against the contents
of the existing file and overwrite only if the content differs, will it work
for you?
> C++ Generator, improve include guard generation
> -----------------------------------------------
>
> Key: AVRO-1079
> URL: https://issues.apache.org/jira/browse/AVRO-1079
> Project: Avro
> Issue Type: Improvement
> Components: c++
> Affects Versions: 1.6.3, 1.7.0
> Reporter: [email protected]
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-1079.patch
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> We integrated avro into our cmake build system. So we have json -> c++ header
> build step which is quite similar to the QT moc-compiler. This build step
> will overwrite the target header-files if the json schema file was modified
> or when the generated header files are different.
> In addition to that we want to put the generated header files under version
> control.
> However, the generated include-guards contains some random parts. This random
> part troubles the version control system. In addition to that this random
> part leads to unnecessary rebuilds as cmake 'thinks' important files have
> been changed and triggers a rebuild of the corresponding dependencies.
> Suggestion:
> Add an additional command line parameter to either switch off the random part
> of the string, or to take a string from the command line and use this as
> include guard.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
