[
https://issues.apache.org/jira/browse/AVRO-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276765#comment-13276765
]
Miki Tebeka commented on AVRO-283:
----------------------------------
AVRO-823.patch is not a patch file. Can you generate a patch with running "svn
diff"?
I like the idea, but I see many problems with the code in AVRO-823.patch
* There are several missing imports/functions (such as datautil,
getSchemaEntity)
* Never use default mutable arguments (json={})
* It's probably better to inherit UserDict
* I don't think you should allow access to the internal _json and friends
* See PEP8 on how to name variables, methods ...
* In line 114 you do {{if index_of_schema < 0}}, however in line 108 it's a list
> Change the new Python implementation from dictionaries to objects
> -----------------------------------------------------------------
>
> Key: AVRO-283
> URL: https://issues.apache.org/jira/browse/AVRO-283
> Project: Avro
> Issue Type: Improvement
> Components: python
> Reporter: Jeff Hammerbacher
> Assignee: Jeff Hammerbacher
> Attachments: AVRO-283.patch, AVRO-283_generic.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
