[
https://issues.apache.org/jira/browse/AVRO-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277137#comment-13277137
]
Vivek Nadkarni commented on AVRO-1092:
--------------------------------------
A few questions regarding the patch, specifically the CMakeLists.txt
file. I am by no means a CMake expert, so apologies if the answers
should be obvious :-).
1. Are THREAD_LIBRARIES and THREADSAFE cmake intrinsic definitions or
are they your definitions?
2. I didn't see why the definition _REENTRANT was set. It isn't used
anywhere in the source. Is it a requirement of pthreads?
3. How do you disable or enable threads (under Linux)? Is there a
reason you didn't use the syntax similar to the zlib and lzma
codecs? For example
find_package(Threads)
if (Threads_FOUND)
message("Threads_FOUND")
# Use threads here.
else (Threads_FOUND)
message("Threads not FOUND")
endif(Threads_FOUND)
Thanks,
Vivek
> avro-c: improving thread safety in error management code
> --------------------------------------------------------
>
> Key: AVRO-1092
> URL: https://issues.apache.org/jira/browse/AVRO-1092
> Project: Avro
> Issue Type: Bug
> Components: c
> Affects Versions: 1.6.3, 1.7.0
> Reporter: Pugachev Maxim
> Priority: Critical
> Attachments: AVRO-1092-patch-2.patch, AVRO-1092.patch
>
>
> Error management code isn`t thread safe at all. I wrote a patch for this
> issue, but it works only for *nix systems.
> Affected functions: avro_set_error(), avro_prefix_error()
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
