[ 
https://issues.apache.org/jira/browse/AVRO-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292378#comment-13292378
 ] 

Joey Echeverria commented on AVRO-1112:
---------------------------------------

Hey Matt,

I did a quick review of your patch, it looks good. I have one nit and one 
suggestion.

Nit: Can you rename OUTPUT_CODEC to CONF_OUTPUT_CODEC to be more consistent?

Suggestion: Can you add a test for this change? I haven't closely at the test 
for the new mapreduce API, so if there isn't an obvious way to test in a unit 
test, that's probably fine.
                
> Java: Snappy codec not supported by Avro mapreduce API
> ------------------------------------------------------
>
>                 Key: AVRO-1112
>                 URL: https://issues.apache.org/jira/browse/AVRO-1112
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.0, 1.7.1
>            Reporter: matt mead
>            Priority: Minor
>              Labels: mapreduce, snappy
>             Fix For: 1.7.1
>
>         Attachments: AVRO-1112.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The implementation of the mapreduce API support does not allow for the user 
> to specify the snappy codec for output compression.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to