[ 
https://issues.apache.org/jira/browse/AVRO-1119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405239#comment-13405239
 ] 

Doug Cutting commented on AVRO-1119:
------------------------------------

The patch looks reasonable to me (a non-Netty expert) and existing tests pass 
with it.  However it is an incompatible API change for anyone who was using the 
old constructor.  So unless we're convinced that the prior version was totally 
unusable we should continue to support it as well.  Also, can you please add a 
test that uses the new constructor?  Thanks!

                
> NettyServer support for SSL
> ---------------------------
>
>                 Key: AVRO-1119
>                 URL: https://issues.apache.org/jira/browse/AVRO-1119
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.6.3, 1.7.0
>            Reporter: Sebastian Ortega
>             Fix For: 1.7.1
>
>         Attachments: 
> 0001-Add-NettyServer-constructor-for-custom-pipelines.patch
>
>
> When trying to use NettyServer with SSL support I have problems despite 
> [AVRO-898] has been accepted. If I am not wrong, the SSLHandler should be 
> added to the worker pipelines but you cannot do that with the current 
> interface.
> I've prepared a patch of a different approach. I've added a new constructor 
> of type ChannelPipelineFactory used to initialize the worker pipeline instead 
> of calling Channels.pipeline() directly. Please see the attached path.
> If I'm wrong, I wil be very grateful to know how to solve it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to