[
https://issues.apache.org/jira/browse/AVRO-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417917#comment-13417917
]
Eli Reisman commented on AVRO-939:
----------------------------------
I noticed in the FastByteComparisons file there were several references to the
original Guava code! I realize what FBC does is expose the indexed comparisons
that Guava does not, but I suspect Guava is already a part of Hadoop and not
yet for Avro.
Any reason not to replace the UnsignedBytes/Longs calls in FastByteComparisons
with something from code already in Sun Java or in Avro already to avoid
bringing the whole Guava library into Avro just for one file that already
duplicates 90% of the Guava code we needed in the first place? Or is it time
for Avro to import Guava anyway for future use?
> Java: optimize BinaryData#compareBytes() to use sun.misc.Unsafe when available
> ------------------------------------------------------------------------------
>
> Key: AVRO-939
> URL: https://issues.apache.org/jira/browse/AVRO-939
> Project: Avro
> Issue Type: New Feature
> Components: java
> Affects Versions: 1.7.1
> Reporter: Doug Cutting
> Attachments: AVRO-939-1.patch, AVRO-939-2.patch, AVRO-939-3.patch
>
>
> Google's Guava libraries include an optimized implementation of lexicographic
> byte comparison based on sun.misc.Unsafe that's ~4x faster than the normal
> Java implementation.
> http://hiroshiyamauchi.blogspot.com/2010/08/fast-unsigned-byte-lexicographical.html
> http://www.google.com/codesearch#UKMs0lhE9bg/trunk/src/com/google/common/primitives/UnsignedBytes.java&l=276
> We might similarly optimize BinaryData#compareBytes().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
