[ 
https://issues.apache.org/jira/browse/AVRO-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Cutting updated AVRO-1147:
-------------------------------

    Attachment: AVRO-1147.patch

I merged your patch and mine.  You missed the case where the map key had a 
@Stringable annotation, also the parameter to writeMapKey can just be a 
Decoder, not a ResolvingDecoder.  Mine was still rough, using the old 
"java-class" property and readString methods rather than defining a new 
property and method as you did.

Does this look reasonable?  If so, I'll commit it.
                
> Allow Stringable Map keys in addition to pure String keys (avro reflection)
> ---------------------------------------------------------------------------
>
>                 Key: AVRO-1147
>                 URL: https://issues.apache.org/jira/browse/AVRO-1147
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.0
>            Reporter: Alexandre Normand
>              Labels: newbie, patch
>         Attachments: AVRO-1147.patch, AVRO-1147.patch
>
>
> I'm using avro reflection for some serialization that doesn't require the 
> best performance for some short-lived data. 
> However, the object I'm trying to serialize uses a {{Map}} with non-String 
> keys (the key class is {{Integer}}) and, because of the strict restriction on 
> Map keys being Strings, it fails. 
> Could we consider allowing Map keys to be *{{Stringable}}* classes (I'm 
> thinking of something similar to Doug's solution in 
> https://issues.apache.org/jira/browse/AVRO-1146)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to