[
https://issues.apache.org/jira/browse/AVRO-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Cutting updated AVRO-1199:
-------------------------------
Attachment: AVRO-1199.patch
Here's a new version of the patch.
I changed deepCopy() to be a generic method, so that calls don't have to cast
the result and updated existing calls to no longer cast the result.
I'll commit this version soon unless someone objects.
> SortedKeyValueFile$Writer.append method have a puzzle for the sorted key
> ------------------------------------------------------------------------
>
> Key: AVRO-1199
> URL: https://issues.apache.org/jira/browse/AVRO-1199
> Project: Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.7.3
> Reporter: Libing Sun
> Labels: patch
> Fix For: 1.7.3
>
> Attachments: AVRO-1199.patch, AVRO-1199.path
>
>
> At the SortedKeyValueFile.java 539 lines like next:
> mPreviousKey = key;
> This class is same as Hadoop's MapFile, at the MapFile the same methon will
> keep a copy for this key, but not use "=".
> If use "=" at here, when user append a reuse key object to this file. will
> cause key sorted not valid.
> I think next code will fix it:
> private DataInputBuffer inBuf = new DataInputBuffer();
> private DataOutputBuffer outBuf = new DataOutputBuffer();
> GenericDatumWriter<K> writer = new ReflectDatumWriter<K>(schema);
> GenericDatumReader<K> reader = new ReflectDatumReader<K>(schema);
> writer.write(key, encoder);
> inBuf.reset(outBuf.getData(), outBuf.getLength());
> BinaryDecoder decoder = DecoderFactory.get().directBinaryDecoder(inBuf,
> null);
> lastKey = reader.read(null, decoder);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira