Yes, please still attach patches to JIRA and ask for review, aside from absolutely trivial changes (e.g. typo in code comment or CHANGES.txt). Typically we wait for comments and review before committing, and we cannot commit if there is a technical objection from another committer. If we do not get a review, we usually give a heads-up in the JIRA ticket like: "I will commit this at the end of the week if there are no objections".
More about our process is here: https://cwiki.apache.org/confluence/display/AVRO/How+To+Contribute#HowToCon tribute-CommittingGuidelinesforcommitters And Apache's information for committers: http://www.apache.org/dev/committers.html Welcome, Martin! -Scott On 3/27/13 4:11 PM, "Martin Kleppmann" <[email protected]> wrote: >Oh wow, thank you ‹ that's a very pleasant surprise! I will sort out the >ICLA. > >I actually have a substantial list of things I was planning to fix >over the next few weeks, so I will get to make good use of this honour >:) > >Once this is set up, how do you prefer to handle commits? Would you >like me to still attach patch files to JIRA before committing them? >I'd appreciate it if you/someone could continue to review any changes >I make, as I find code reviews very valuable. (I'm happy to review >others' changes too, where I am qualified to do so.) But I'm happy to >fit into whatever process you've got set up. > >Thanks again, >Martin > >On 27 March 2013 20:25, Doug Cutting <[email protected]> wrote: >> The Avro PMC has voted to add Martin Kleppmann as a committer. >> >> Congratulations, Martin! >> >> If you accept, you need to file an Individual Contributor License >> Agreement (ICLA): >> >> http://www.apache.org/licenses/#clas >> >> Once this are on file we can ask for your Apache account to be created. >> >> For more info about being an Apache committer, see: >> >> http://www.apache.org/dev/new-committers-guide.html >> http://www.apache.org/dev/committers.html >> >> Doug
