[ 
https://issues.apache.org/jira/browse/AVRO-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630760#comment-13630760
 ] 

Doug Cutting commented on AVRO-1287:
------------------------------------

This looks like a fine way to add this into the build, but it causes PHP tests 
to fail.

If I update the regex in InterOpTest.php as follows:

{code}
-      if (0 < preg_match('/.*\.avro$/', $file))
+      if (0 < preg_match('/^[a-z]+\.avro$/', $file))
{code}

then tests pass.
                
> Interop tests should test codecs as well
> ----------------------------------------
>
>                 Key: AVRO-1287
>                 URL: https://issues.apache.org/jira/browse/AVRO-1287
>             Project: Avro
>          Issue Type: Test
>          Components: build
>    Affects Versions: 1.7.4
>            Reporter: Martin Kleppmann
>            Assignee: Martin Kleppmann
>         Attachments: AVRO-1287.patch
>
>
> Currently the interop tests for data files only generate and parse a data 
> file with null codec in each language. Given that the deflate codec is also a 
> required codec in the spec, we should be testing interop on deflate (and 
> optionally snappy, too).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to