[
https://issues.apache.org/jira/browse/AVRO-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641197#comment-13641197
]
Scott Carey commented on AVRO-1282:
-----------------------------------
{code}
static Accessor getAccessor(Object o) {
Class c = o.getClass().getComponentType();
if (c == int.class)
return new IntAccessor(o);
if (c == long.class)
return new LongAccessor(o);
if (c == byte.class)
return new ByteAccessor(o);
if (c == float.class)
return new FloatAccessor(o);
if (c == double.class)
return new DoubleAccessor(o);
if (c == char.class)
return new CharAccessor(o);
if (c == short.class)
return new ShortAccessor(o);
return null;
}
}
{code}
Is c == int.class guaranteed to work across classloaders? is int.class in one
classloader == to int.class in another? Otherwise we'll need to use instanceof
(which is fast).
> Make use of the sun.misc.Unsafe class during serialization if a JDK supports
> it
> -------------------------------------------------------------------------------
>
> Key: AVRO-1282
> URL: https://issues.apache.org/jira/browse/AVRO-1282
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.7.4
> Reporter: Leo Romanoff
> Priority: Minor
> Attachments: avro-1282-v1.patch, avro-1282-v2.patch,
> avro-1282-v3.patch, avro-1282-v4.patch, avro-1282-v5.patch,
> avro-1282-v6.patch, avro-1282-v7.patch, avro-1282-v8.patch
>
>
> Unsafe can be used to significantly speed up serialization process, if a JDK
> implementation supports java.misc.Unsafe properly. Most JDKs running on PCs
> support it. Some platforms like Android lack a proper support for Unsafe yet.
> There are two possibilities to use Unsafe for serialization:
> 1) Very quick access to the fields of objects. It is way faster than with the
> reflection-based approach using Field.get/set
> 2) Input and Output streams can be using Unsafe to perform very quick
> input/output.
>
> 3) More over, Unsafe makes it possible to serialize to/deserialize from
> off-heap memory directly and very quickly, without any intermediate buffers
> allocated on heap. There is virtually no overhead compared to the usual byte
> arrays.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
