[
https://issues.apache.org/jira/browse/AVRO-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751521#comment-13751521
]
Doug Cutting commented on AVRO-1268:
------------------------------------
Christophe, are you referring to the toString() call in
SpecificDatumWriter#writeString()? You're right, this does loosen type safety.
This could perhaps be fixed if the code changed to something like:
{code}
if (!(datum instanceof CharSequence) &&
getData().isStringable(datum.getClass()))
datum = datum.toString();
{code}
If that sounds reasonable, please file an issue. Thanks!
> Add java-class, java-key-class and java-element-class support for stringable
> types to SpecificData
> --------------------------------------------------------------------------------------------------
>
> Key: AVRO-1268
> URL: https://issues.apache.org/jira/browse/AVRO-1268
> Project: Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.7.4
> Reporter: Alexandre Normand
> Assignee: Alexandre Normand
> Priority: Minor
> Fix For: 1.7.5
>
> Attachments: AVRO-1268-MapSolution.patch, AVRO-1268-needs-work.patch,
> AVRO-1268.patch, AVRO-1268.patch, AVRO-1268.patch,
> AVRO-1268-performance.patch, AVRO-1268.sh, GenericStringsPerf.patch,
> pseudo.patch, pseudo.patch
>
>
> Stringable types are java classes that can be serialized through strings
> (which require a single string constructor and a valid toString()
> implementation). ReflectData currently has support from stringable types but
> it would be desirable to get this feature with SpecificData.
> The work involves changes to the SpecificCompiler (depends on {{@java-class}}
> support in AVRO-1267) to generate the specific sources with the proper java
> type as well as moving the ReflectDatumReader and ReflectDatumWriter to read
> the java-class/java-key-class and java-element-class properties.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
