[ https://issues.apache.org/jira/browse/AVRO-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793914#comment-13793914 ]
Christophe Taton commented on AVRO-1385: ---------------------------------------- Hey Doug, When you say we shouldn't silently discard information, what is your opinion on the "promotion" of int to float, or long to float/double? These promotions may cause data precision loss, since the 31 bits of an int do not fit in the 23 bits of a float. If these conversions are OK, should double also be allowed for promotion as float? C. > Enum reader/writer resolution doesn't report errors > --------------------------------------------------- > > Key: AVRO-1385 > URL: https://issues.apache.org/jira/browse/AVRO-1385 > Project: Avro > Issue Type: Bug > Components: java > Affects Versions: 1.7.5 > Reporter: Christophe Taton > Attachments: > AVRO-1385.base=a56e7f13c4fa976b7926649b058665f42850a349.20131010-182234.patch > > > According to the specification, when a reader enum does not contain all > symbols from the writer enum, an error should be signaled. > ResolvingGrammarGenerator fails to report such errors. > In particular, mkEnumAdjust() silently maps unknown symbols of the writers > with symbols named "No match for [writer symbol]". > https://github.com/apache/avro/blob/trunk/lang/java/avro/src/main/java/org/apache/avro/io/parsing/ResolvingGrammarGenerator.java#L409 > Shouldn't this instead create an ErrorAction? -- This message was sent by Atlassian JIRA (v6.1#6144)