[ 
https://issues.apache.org/jira/browse/AVRO-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David McIntosh updated AVRO-1332:
---------------------------------

    Attachment: AVRO-1332-missing-files-plus-defaults-patch.patch
                AVRO-1332-defaults-patch-only.patch

I've noticed two problems with this patch. The first is that only the modified 
files from the patch got committed into SVN. The newly added files were missed. 
I also found a bug with default value handling that was introduced with this 
patch. I adjusted the unit tests to trigger it and have made a fix.

The "defaults-patch-only" patch includes only the new fix. The 
"missing-fles-plus-defaults-patch" patch includes the fix and the files from 
the "-4" patch that didn't make it into svn.

If needed I can submit the defaults fix as a separate issue.

> Improve C# DatumReader performance
> ----------------------------------
>
>                 Key: AVRO-1332
>                 URL: https://issues.apache.org/jira/browse/AVRO-1332
>             Project: Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.7.5
>            Reporter: David McIntosh
>            Assignee: David McIntosh
>            Priority: Minor
>              Labels: performance
>             Fix For: 1.7.6
>
>         Attachments: AVRO-1332-2.patch, AVRO-1332-3.patch, AVRO-1332-4.patch, 
> AVRO-1332-defaults-patch-only.patch, 
> AVRO-1332-missing-files-plus-defaults-patch.patch, AVRO-1332.patch
>
>
> The current implementations of the C# datum readers perform resolution of the 
> reader and writer schema on every call to Read. In my tests this was causing 
> it to perform poorly when reading a large number of records (slower than 
> parsing the same data from delimited text files). It would be more efficient 
> if the reader only needed to resolve the schemas once.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to