[
https://issues.apache.org/jira/browse/AVRO-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087463#comment-14087463
]
Dmitry Kovalev commented on AVRO-1342:
--------------------------------------
Yes I am also running on a modified 1.7.6 but so far my changes were minimal
and general enough, so I saw it as a good moment to contribute them back and be
able to run on official distribution w/o modifications. May I use this
opportunity to get you guys to review also AVRO-1556, AVRO-1491 and AVRO-843 -
they are all very small and easy to check, but do fix important issues which
otherwise make official distribution "less likely" to be used as is without
having to change anything on source level. This issue, the three mentioned
above and AVRO-1555 together constitute all changes that I had to make to use
C# Avro IPC in a production system with a fairly complex protocol.
Re unit test for this one - it is not obvious immediately how to model this
situation in a controlled way. I will try dynamically generating and loading an
assembly which references a non-existent assembly and then calling objectreator
- but this is likely to involve much more effort and code than the actual fix.
> ObjectCreator fails if bad assemblies loaded
> --------------------------------------------
>
> Key: AVRO-1342
> URL: https://issues.apache.org/jira/browse/AVRO-1342
> Project: Avro
> Issue Type: Bug
> Components: csharp
> Affects Versions: 1.7.4
> Environment: Windows, Visual Studio
> Reporter: David Taylor
> Fix For: 1.7.8
>
> Attachments: AVRO-1342-csharp-ObjectCreator-fix.patch,
> continue-on-exception.diff
>
>
> When iterating over the list of assemblies in ObjectCreator.cs the GetTypes()
> call can fail with an exception if there is a load error on an assembly.
> Currently this exception is propagated but really does not need to be. I
> think a more reasonable approach is to note the error and then try the next
> assembly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
