[
https://issues.apache.org/jira/browse/AVRO-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ujjwal updated AVRO-1560:
-------------------------
Description:
The current CMakeLists.txt does not account for Snappy include folders causing
the compilation to fail when a custom snappy location is provided using
-DSNAPPY_ROOT_DIR
e.g .
{code:xml}
cmake avro-c-1.7.7 -DSNAPPY_ROOT_DIR=${SNAPPY_INSTALL_DIR}
{code}
In https://github.com/apache/avro/blob/release-1.7.7/lang/c/CMakeLists.txt#L143
we should include
{code:xml}
include_directories(${SNAPPY_INCLUDE_DIR})
{code}
was:
The current CMakeLists.txt does not account for Snappy include folders causing
the compilation to fail when a custom compiled snappy is provided.
In https://github.com/apache/avro/blob/release-1.7.7/lang/c/CMakeLists.txt#L143
we should include
{code:xml}
include_directories(${SNAPPY_INCLUDE_DIR})
{code}
> SNAPPY_INCLUDE_DIR not accounted in CMakeLists.txt
> --------------------------------------------------
>
> Key: AVRO-1560
> URL: https://issues.apache.org/jira/browse/AVRO-1560
> Project: Avro
> Issue Type: Bug
> Components: c
> Affects Versions: 1.7.7
> Reporter: Ujjwal
> Priority: Minor
> Labels: build
> Attachments: AVRO-1560.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current CMakeLists.txt does not account for Snappy include folders
> causing the compilation to fail when a custom snappy location is provided
> using -DSNAPPY_ROOT_DIR
> e.g .
> {code:xml}
> cmake avro-c-1.7.7 -DSNAPPY_ROOT_DIR=${SNAPPY_INSTALL_DIR}
> {code}
> In
> https://github.com/apache/avro/blob/release-1.7.7/lang/c/CMakeLists.txt#L143
> we should include
> {code:xml}
> include_directories(${SNAPPY_INCLUDE_DIR})
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
