[ 
https://issues.apache.org/jira/browse/AVRO-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158468#comment-14158468
 ] 

Doug Cutting commented on AVRO-570:
-----------------------------------

The minimal patch does look better.  CAn

A few minor Java style issues:
 - the enum PROTOCOL should be Protocol, no?
 - x.compareTo(y) == 0 should be x.equals(y), no?
 - we avoid version literals in dependencies, but instead refer to version 
variables in lang/java/pom.xml, so all versions are centralized and so they can 
be overridden
 - since commons-cli is only used in tools, the dependency should be added 
there, no?

I guess we could label the Python API as 'experimental'.  If we include this in 
1.8 then normally we'd not permit incompatible API changes until 1.9.  (We try 
to make point release upgrades risk-free.)  But if we clearly mark this new API 
as 'evolving' in the release notes & other documentation then we might make an 
exception to that rule here.

> python implementation of mapreduce connector
> --------------------------------------------
>
>                 Key: AVRO-570
>                 URL: https://issues.apache.org/jira/browse/AVRO-570
>             Project: Avro
>          Issue Type: New Feature
>          Components: python
>    Affects Versions: 1.7.0
>            Reporter: Doug Cutting
>            Assignee: Jeremy Lewi
>            Priority: Critical
>              Labels: hadoop
>             Fix For: 1.8.0
>
>         Attachments: AVRO-570.patch, AVRO-570.patch, AVRO-570.patch, 
> AVRO-570.patch, AVRO-570.patch, AVRO-570.patch, AVRO-570.patch, AVRO-570.patch
>
>
> AVRO-512 defines protocols for implementing mapreduce tasks.  It would be 
> good to have a Python implementation of this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to