[ 
https://issues.apache.org/jira/browse/AVRO-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryan Blue updated AVRO-1602:
----------------------------
    Attachment: AVRO-1602-1.patch

This patch fixes the problems with the now-flaky TestFileSpanStorage test, as 
well as the underlying bugs that were exposed:

1. File resolution was not done correctly unless secondsPerFile = 1
2. Span time range calculation was incorrect
3. Duplicate Spans returned if startTime = endTime for file cutoff times

[~dbl001], would you mind checking that this fixes the problem for you?

> FAILURE! - in org.apache.avro.ipc.trace.TestFileSpanStorage
> -----------------------------------------------------------
>
>                 Key: AVRO-1602
>                 URL: https://issues.apache.org/jira/browse/AVRO-1602
>             Project: Avro
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.7.7
>         Environment: Mac OS X 10.10 Yosemite
>            Reporter: David Laxer
>         Attachments: AVRO-1602-1.patch, Screen Shot 2014-11-10 at 9.01.12 
> AM.png
>
>
> Running org.apache.avro.ipc.trace.TestFileSpanStorage
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 9.995 sec <<< 
> FAILURE! - in org.apache.avro.ipc.trace.TestFileSpanStorage
> testRangeQuery1(org.apache.avro.ipc.trace.TestFileSpanStorage)  Time elapsed: 
> 0.363 sec  <<< FAILURE!
> java.lang.AssertionError: expected:<8> but was:<4>
>       at org.junit.Assert.fail(Assert.java:88)
>       at org.junit.Assert.failNotEquals(Assert.java:743)
>       at org.junit.Assert.assertEquals(Assert.java:118)
>       at org.junit.Assert.assertEquals(Assert.java:555)
>       at org.junit.Assert.assertEquals(Assert.java:542)
>       at 
> org.apache.avro.ipc.trace.TestFileSpanStorage.testRangeQuery1(TestFileSpanStorage.java:159)
> I see this issue:
> http://apache-avro.679487.n3.nabble.com/Build-failed-in-Jenkins-AvroJava-475-td4030947.html
> Is there a work-around?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to