[ 
https://issues.apache.org/jira/browse/AVRO-1608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tom White updated AVRO-1608:
----------------------------
    Attachment: AVRO-1608.patch

I've updated the patch to remove usage of the deprecated methods, although it's 
not finished yet. Still to do:
* The IDL code needs to be converted to use the constructors that take 
properties and aliases, rather than calling the setters. This should be similar 
to the changes required in SpecificCompiler.
* TestWordCount uses ReflectData.get().getSchema() to get a schema for a class 
then calls addAlias() on it. We need to pass aliases to the getSchema() so they 
can be applied at construction time.
* See if it's possible to avoid making Name public, by using a String to 
represent the full name.

I haven't looked at Schema.setFields.

> Deprecate mutator methods on Schema
> -----------------------------------
>
>                 Key: AVRO-1608
>                 URL: https://issues.apache.org/jira/browse/AVRO-1608
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.7
>            Reporter: Tom White
>            Assignee: Tom White
>             Fix For: 1.7.8
>
>         Attachments: AVRO-1608.patch, AVRO-1608.patch
>
>
> This is a follow on to AVRO-261. It would be good to deprecate 
> JsonProperties#addProp, Schema#addAlias, and Schema.Field#addAlias, and 
> remove them in 1.8.0. Instead users should use SchemaBuilder, or we could 
> also provide overloaded variants of the factory methods on Schema to specify 
> properties and aliases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to