Thanks for this summary Ryan. I have also found github to be more useful than submitting patch-files.
Hope to see more PRs in future. sg On Tue, Mar 31, 2015 at 2:22 PM, Ryan Blue <[email protected]> wrote: > Hi everyone, > > There have been more github pull requests lately, partly because I like > that for reviewing contributions. I like to be able to comment on specific > lines and have a bit more detailed discussion. > > I just wanted to share a couple of good things to know: > > * The github JIRA comments have a link to a PR patch file, if you prefer > patches. > * The patch link gets the latest changes when the PR is updated. > * To close a PR when you commit a change, just add a comment like "Closes > #18". Otherwise we can't close them. > > Lately I've been using github as an alternate remote so I can fetch all of > the PRs at once and cherry pick into my git-svn branch. That works pretty > well and removes the problem of remembering to add files that are in a > patch but not added to git or svn. > > Hopefully that's helpful to others. Thanks, > > rb > > > -- > Ryan Blue > Software Engineer > Cloudera, Inc. >
