[
https://issues.apache.org/jira/browse/AVRO-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389676#comment-14389676
]
Hudson commented on AVRO-1652:
------------------------------
SUCCESS: Integrated in AvroJava #516 (See
[https://builds.apache.org/job/AvroJava/516/])
AVRO-1652. Java: Do not warn or validate defaults if validation is off.
Contributed by Michael D'Angelo. (blue: rev 1670516)
* /avro/trunk/CHANGES.txt
* /avro/trunk/lang/java/avro/src/main/java/org/apache/avro/Schema.java
> Java - Schema.Field prints out System.err [WARNING] even though
> validateDefaults is set to false.
> -------------------------------------------------------------------------------------------------
>
> Key: AVRO-1652
> URL: https://issues.apache.org/jira/browse/AVRO-1652
> Project: Avro
> Issue Type: Bug
> Affects Versions: 1.7.7
> Environment: Java
> Reporter: Michael D'Angelo
> Assignee: Michael D'Angelo
> Priority: Minor
> Attachments: AVRO-1652.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Inside of Schema.Field we see the following chunk of code:
> {code:title=Schema.java|borderStyle=solid}
> private static JsonNode validateDefault(String fieldName, Schema schema,
> JsonNode defaultValue) {
> if ((defaultValue != null)
> && !isValidDefault(schema, defaultValue)) { // invalid default
> String message = "Invalid default for field "+fieldName
> +": "+defaultValue+" not a "+schema;
> if (VALIDATE_DEFAULTS.get())
> throw new AvroTypeException(message); // throw exception
> System.err.println("[WARNING] Avro: "+message); // or log warning
> }
> return defaultValue;
> }
> {code}
> The code checks to see if we should be validating the defaults and will only
> print the Exception if we are. The code always prints the WARNING out to
> System.err, though.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
