[ 
https://issues.apache.org/jira/browse/AVRO-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492655#comment-14492655
 ] 

Ryan Blue commented on AVRO-1497:
---------------------------------

bq. Did you average the times over a few runs?

No, I haven't but I'll run a few more tests. It looks like most of the ones 
that have changed more than 5% are either not going through the data model 
(like {{ValidatingRecordRead}} and {{GenericNestedFake_Write}}) or are for 
other reasons likely due to variance ({{IntRead}} is small, 
{{GenericStringsWrite}} is faster). The ones I'm still not sure about are the 
reflect double and long array tests I noted above, but those are reading 
approximately the same amount of data and going through the same methods, other 
than the underlying decoder. I'll run some more tests, but I don't see a reason 
for either performance gain or loss. Overall I think that these runs don't flag 
any concerns with the addition, which makes sense because it is essentially a 
hash table lookup and a couple additional null tests.

> Add LogicalType support to Java
> -------------------------------
>
>                 Key: AVRO-1497
>                 URL: https://issues.apache.org/jira/browse/AVRO-1497
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Ryan Blue
>            Assignee: Zoltan Farkas
>             Fix For: 1.7.8
>
>         Attachments: Logical Types Performance Comparison - Sheet1.csv
>
>
> AVRO-1402 updates the Avro spec to include logical types, which are stored as 
> existing types but interpreted as others. The next step is to implement 
> LogicalType (in Java) that provides tools to attach a logical type to a 
> schema, read a logical type, and validate logical types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to