[
https://issues.apache.org/jira/browse/AVRO-1698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621342#comment-14621342
]
svante karlsson commented on AVRO-1698:
---------------------------------------
Don't think I'll have time for writing testcases for this - but take a look
here...
http://apr.apache.org/docs/apr/2.0/group__apr__ctype.html
you really need the cast.
> cant serialize json with characters >127 when compiling with signed char
> ------------------------------------------------------------------------
>
> Key: AVRO-1698
> URL: https://issues.apache.org/jira/browse/AVRO-1698
> Project: Avro
> Issue Type: Bug
> Components: c++
> Affects Versions: 1.7.7
> Environment: windows, linux w signed char
> Reporter: svante karlsson
> Attachments: AVRO-1698.1.patch
>
>
> iscntrl assumes 0-255 but signed char gets expanded to bad things
> pullreq #38 on github solves the issue.
> change line 196 lang/c++/impl/json/JsonIO.hh
> from
> if (! iscntrl(*p)) {
> to
> if (! iscntrl((uint8_t) *p)) {
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
