[ 
https://issues.apache.org/jira/browse/AVRO-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14623615#comment-14623615
 ] 

Ryan Blue commented on AVRO-1692:
---------------------------------

[~tomwhite], I've updated the PR for Sean's review comments and added the test 
I made that demonstrates using logical types to implement circular references, 
AVRO-695. I didn't use the time types because they are not yet synced in 
github, but the circular reference test validates using multiple logical types 
with the same underlying Java class.

I think this is ready to go now. Thanks!

> Allow more than one logical type for a Java class
> -------------------------------------------------
>
>                 Key: AVRO-1692
>                 URL: https://issues.apache.org/jira/browse/AVRO-1692
>             Project: Avro
>          Issue Type: Task
>          Components: java
>            Reporter: Ryan Blue
>            Assignee: Ryan Blue
>             Fix For: 1.8.0
>
>         Attachments: AVRO-1692.1.patch
>
>
> The initial logical types implementation assumed that there would only be one 
> logical type per concrete class and kept a lookup table from class to 
> conversion. There are cases where this assumption doesn't work. For example, 
> both time-millis and time-micros can be represented by the same class, 
> LocalTime, and the write path should use the correct logical type's 
> conversion depending on the schema.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to