[ 
https://issues.apache.org/jira/browse/AVRO-1760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15034310#comment-15034310
 ] 

Ryan Blue commented on AVRO-1760:
---------------------------------

[~mulugeta], could you run your test with the guava cache to see if it fixes 
the performance bug?

I think we can also modify the cache from PR #30 to avoid so many calls to the 
reap method. There's not a correctness problem if we remove the calls to reap 
in put, get, and remove because they all have strong references to the key, so 
it can't have been garbage collected. Limiting the reap calls to just size, 
values, keySet, etc. would probably fix the problem. If guava doesn't fix the 
problem, then maybe we could fix it with this class after all.

> Thread scalability problem with the use of SynchronizedMap
> ----------------------------------------------------------
>
>                 Key: AVRO-1760
>                 URL: https://issues.apache.org/jira/browse/AVRO-1760
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.4, 1.7.5, 1.7.6, 1.7.7, 1.8.0, 1.8.1, 1.9.0
>            Reporter: Mulugeta Mammo
>            Priority: Critical
>              Labels: patch, performance
>             Fix For: 1.7.4, 1.7.5, 1.7.6, 1.7.7, 1.7.8, 1.8.0, 1.8.1, 1.9.0
>
>         Attachments: AVRO-1760.patch, AVRO-1760.pdf
>
>
> While running Adam Genomics (which uses Avro) on Apache Spark, we discovered 
> that threads (tasks in Spark Context) block in Avro while executing the 
> getDefaultValue(Field field) method in 
> https://github.com/apache/avro/blob/trunk/lang/java/avro/src/main/java/org/apache/avro/generic/GenericData.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to