[ 
https://issues.apache.org/jira/browse/AVRO-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15045660#comment-15045660
 ] 

Ryan Blue commented on AVRO-1728:
---------------------------------

I'm updating the patch to the latest version. Here's a summary of the 
significant changes:

* Fixed the Javadoc jar for avro-tools. Previously, it included the entries for 
all of the shaded dependencies, which isn't necessary.
* The NOTICE for the shaded avro-tools jar now contains, verbatim, the NOTICE 
content from dependencies that are shaded so that the dependency copyright 
notices are intact.
* Updated how Odiago's contribution to mapred is documented. Because the 
content was contributed to the project, not licensed as a third-party work, the 
project's Apache license applies and the contribution should not be listed 
separately (no other contribution to the project is). However, because of the 
confusion I've included a clear description of the contribution history and 
relevant NOTICE content to the NOTICE file.

I also checked to make sure the other jar license and notice files are correct. 
The compiler, mapred, and tools modules have extra information. For compiler 
and mapred, this applies to the compiled jar, source jar and javadoc jar 
because the information applies to the source content (it is also in the root 
license and notice). For the tools module, the javadoc jar has its own license 
and notice because it is derived from the source without shading and should not 
include the shaded dependency information. The compiled jar and source jar have 
the license and notice that includes information about shaded dependencies. 
This only applies to the content of the compiled jar, but I don't see a way to 
exclude it from the source jar. The information is clearly marked where it 
applies to the binary jar and states "license for X, included in the binary 
artifact". I think that is clear and unambiguous.

> Update LICENSE and NOTICE files included in Java binaries
> ---------------------------------------------------------
>
>                 Key: AVRO-1728
>                 URL: https://issues.apache.org/jira/browse/AVRO-1728
>             Project: Avro
>          Issue Type: Sub-task
>          Components: java
>    Affects Versions: 1.8.0
>            Reporter: Ryan Blue
>            Assignee: Ryan Blue
>             Fix For: 1.8.0
>
>         Attachments: AVRO-1728.1.patch, AVRO-1728.2.patch, AVRO-1728.3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to