[
https://issues.apache.org/jira/browse/AVRO-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047613#comment-15047613
]
Hudson commented on AVRO-1767:
------------------------------
SUCCESS: Integrated in AvroJava #559 (See
[https://builds.apache.org/job/AvroJava/559/])
AVRO-1767: Fall back to unwrapped union values. Contributed by Matthieu Monsch.
Previously, union wrapping during `type.clone` calls would be done in
place of normal copy. Now it is done as a backup if a normal copy fails.
This is more consistent with the documentation, and makes it much
simpler to wrap nested unions.
Other changes:
+ Add an optional argument to `type.getName` to expose built-in type
names (useful to implement an "optional" logical type for example).
+ Document (and rename) `assertLogicalTypes` parsing option.
+ Tweak logical type validity check, enabling error hooks to work even
when a logical type is valid for a subset of its underlying type's
values (e.g. when defining an "even integer" type). Previously the
path would have been correct but the type would have been that of the
underlying one. (blue: rev 1718715)
* trunk/CHANGES.txt
* trunk/lang/js/doc/API.md
* trunk/lang/js/lib/schemas.js
* trunk/lang/js/test/test_schemas.js
> Simplify union wrapping logic.
> ------------------------------
>
> Key: AVRO-1767
> URL: https://issues.apache.org/jira/browse/AVRO-1767
> Project: Avro
> Issue Type: Improvement
> Components: javascript
> Reporter: Matthieu Monsch
> Assignee: Ryan Blue
> Fix For: 1.8.0
>
> Attachments: AVRO-1767.patch
>
>
> Previously, union wrapping during `type.clone` calls would be done in place
> of normal copy. Now it is done as a backup if a normal copy fails. This is
> more consistent with the documentation, and makes it much simpler to wrap
> nested unions.
> See here for more information and examples:
> https://github.com/mtth/avsc/issues/16
> Other changes:
> + Add an optional argument to `type.getName` to expose built-in type names
> (useful to implement an "optional" logical type for example).
> + Document (and rename) `assertLogicalTypes` parsing option.
> + Tweak logical type validity check, enabling error hooks to work even when a
> logical type is valid for a subset of its underlying type's values (e.g.
> when
> defining an "even integer" type). Previously the path would have been
> correct
> but the type would have been that of the underlying one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
