[ 
https://issues.apache.org/jira/browse/AVRO-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072905#comment-15072905
 ] 

Douglas Creager commented on AVRO-1663:
---------------------------------------

Patch looks good.  In {{split_namespace_name}}, you can use {{strrchr(3)}} to 
find the last dot instead of walking the string manually.

Re API change policy, we've introduced breaking changes before during minor 
version bumps, so we could do this since the next release will be 1.8.0.  But I 
think I like your "new functions" suggestion better.

> C Library does not handle enum's namespace
> ------------------------------------------
>
>                 Key: AVRO-1663
>                 URL: https://issues.apache.org/jira/browse/AVRO-1663
>             Project: Avro
>          Issue Type: Bug
>          Components: c
>    Affects Versions: 1.7.7
>            Reporter: Thomas Sanchez
>            Assignee: Martin Kleppmann
>         Attachments: AVRO-1663-2.patch, AVRO-1663-3.patch, AVRO-1663.patch
>
>
> {code}{
>   "type": "record",
>   "name": "EventName",
>   "namespace": "com.company.avro.schemas",
>   "fields": [
>     {"name": "eventname_model",
>      "type": {
>        "type": "enum",
>        "namespace": "com.company.models",
>        "name": "EventName",
>        "symbols": ["XXXX"]
>      }
>     }
>  ]
> }
> {code}
> Such a schema is perfectly valid but the C library does no handle it because 
> it does not parse the namespace field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to