-1 (non-binding) bad: * the artifact avro-doc-1.8.0.tar.gz has no LICENSE/NOTICE files * the avro-tools jar fails with NPE[1]
I'll file issues. mixed: * ruby successfully loads and I can run some simple IO, but phunt's avro-rpc-quickstart fails[2]. I'm not sure yet if the failure is expected given the changes in 1.8.0. good: * other LICENSE/NOTICE spot-check looks fine * signatures match * checksums match * tag matches src tarball, ignoring one nit Only in avro-src/avro-src-1.8.0/lang/java/mapred/src/test/ resources/org/apache/avro/mapreduce/mapreduce-test-input.avro: SUCCESS.crc [1]: busbey$ java -jar avro-tools-1.8.0.jar Version 1.8.0 of Exception in thread "main" java.lang.NullPointerException at org.apache.avro.tool.Main.printStream(Main.java:105) at org.apache.avro.tool.Main.run(Main.java:92) at org.apache.avro.tool.Main.main(Main.java:74) busbey$ java -jar avro-tools-1.8.0.jar --help Version 1.8.0 of Exception in thread "main" java.lang.NullPointerException at org.apache.avro.tool.Main.printStream(Main.java:105) at org.apache.avro.tool.Main.run(Main.java:92) at org.apache.avro.tool.Main.main(Main.java:74) looks like the tooling looks for NOTICE.txt at the top level and we don't have one there anymore :( https://github.com/apache/avro/blob/trunk/lang/java/tools/src/main/java/org/apache/avro/tool/Main.java#L92 [2]: https://github.com/phunt/avro-rpc-quickstart busbey$ ruby sample_ipc_client.rb avro_user pat Hello_World Avro::IO::AvroTypeError: The datum "\x89\xA9\xD1\xFF@NUm\xEA\x9A\xFB\xDAx\xF5Zq" is not an example of schema {"type":"fixed","name":"MD5","namespace":"org.apache.avro.ipc","size":16} write_data at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/io.rb:543 write_record at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/io.rb:610 each at org/jruby/RubyArray.java:1613 write_record at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/io.rb:609 write_data at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/io.rb:561 write at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/io.rb:538 write_handshake_request at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/ipc.rb:136 request at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/ipc.rb:105 request at /Users/busbey/.rvm/gems/jruby-1.7.3/gems/avro-1.8.0/lib/avro/ipc.rb:117 (root) at sample_ipc_client.rb:49 On Wed, Jan 6, 2016 at 9:16 AM, Tom White <[email protected]> wrote: > I've created another release candidate for Avro 1.8.0 that fixes the > problems found in rc1. (Thanks to Ryan and Martin for the patches to fix > them.) > > The changes are listed at: > http://s.apache.org/avro180 > > The release artifacts can be found here: > https://dist.apache.org/repos/dist/dev/avro/avro-1.8.0-rc2/ > > The tag corresponding to this release candidate is: > http://svn.apache.org/repos/asf/avro/tags/release-1.8.0-rc2/ > > You can find the KEYS file here: > https://dist.apache.org/repos/dist/release/avro/KEYS > > The Maven staging repository is at: > https://repository.apache.org/content/repositories/orgapacheavro-1004/ > > Please download, verify, and test. The vote will remain open for at least > 72 hours. Again, this is the first release that has been built using > Docker, so please pay extra attention to the languages you are interested > in. Thanks in advance for voting! > > Cheers, > Tom > -- Sean
