Sean Busbey created AVRO-1781:
---------------------------------

             Summary: Schema.
                 Key: AVRO-1781
                 URL: https://issues.apache.org/jira/browse/AVRO-1781
             Project: Avro
          Issue Type: Bug
          Components: java
    Affects Versions: 1.8.0
            Reporter: Sean Busbey
            Priority: Blocker
             Fix For: 1.8.0


Post AVRO-1497, Schema.parse calls {{LogicalTypes.fromSchemaIgnoreInvalid}} on 
any schema that is expressed as a JSON object (anything except bare primitives).

That static method relies on a static cache based on WeakIdentityHashMap (WIHM).

WIHM clearly states that it isn't threadsafe 
[ref|https://github.com/apache/avro/blob/branch-1.8/lang/java/avro/src/main/java/org/apache/avro/util/WeakIdentityHashMap.java#L42]

{code}
 * 
 * Note that this implementation is not synchronized.
 * </b>
 */
public class WeakIdentityHashMap<K, V> implements Map<K, V> {
{code}

All of the Schema.Parser instances use that same static Schema.parse method.

The end result is that as-is it's only safe to have a single thread parsing 
schemas in a given JVM.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to