GitHub user ncarroll-mdsol opened a pull request:
https://github.com/apache/avro/pull/68
Move management of the file stream into DataFileWriter
I realize there's another process for submitting changes to Avro, but it
looked like the Pull Requests on this repository did get some attention and I
figured this might be a good way to get some preliminary feedback.
The goal of this change is to be able to pass an OutputStream* into
DataFileWriter, so that I can still maintain control of the stream and read
it's data (using an InputStream) after the schema + data has been written. It
looks like you can currently do this in the Java build, but not C++.
My main worry with this approach is that the Public DataFileWriterBase now
takes a raw pointer to an OutputStream, and will no longer manage it using
auto_ptr. Let me know if there's another way to go about this, or if I can
achieve the end goal using different methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ncarroll-mdsol/avro
manage_filestream_in_data_file_writer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit 830268af8282dea845de50df837121d5310d010d
Author: Nolan Carroll <[email protected]>
Date: 2016-01-29T17:26:55Z
Move management of the file stream into DataFileWriter, to allow
DataFileWriterBase to act on a stream which it does not own.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
