Hi Zoltan, I just posted a review. I'd like you to take a look at some changes to the patch I made, but overall the diagnosis and approach you took is sound. Thanks for the fix!
rb On Tue, Mar 1, 2016 at 9:53 AM, Zoltan Farkas <[email protected]> wrote: > Can somebody look at this patch? > > thank you > > —Z > > > On Feb 18, 2016, at 11:04 PM, Zoltan Farkas <[email protected]> > wrote: > > > > Hi Ryan, > > > > did you have a chance to look at the patch? > > > > thank you > > > > —Z > > > > > >> On Feb 13, 2016, at 8:06 AM, Zoltan Farkas <[email protected]> > wrote: > >> > >> Done, you have now a patch attached to the JIRA + a reference to a > feature branch. > >> > >> let me know if you need anything else > >> > >> thank you > >> > >> —Z > >> > >>> On Feb 13, 2016, at 7:32 AM, Zoltan Farkas > <[email protected]> wrote: > >>> > >>> Sure, will attach a path to AVRO-1667. > >>> > >>> > >>> —Z > >>> > >>> > >>>> On Feb 12, 2016, at 7:40 PM, Ryan Blue <[email protected]> > wrote: > >>>> > >>>> Hi Zoltan, > >>>> > >>>> I remember taking a look at this a couple months ago. I think we can > get it > >>>> in, but it isn't in a state where we can review it very easily > because it > >>>> mixes both AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> > and > >>>> AVRO-1723 <https://issues.apache.org/jira/browse/AVRO-1723>. Could > you help > >>>> us get AVRO-1667 <https://issues.apache.org/jira/browse/AVRO-1667> > in first > >>>> by putting together a clean patch with it? > >>>> > >>>> rb > >>>> > >>>> On Fri, Feb 12, 2016 at 8:44 AM, Zoltan Farkas > <[email protected] > >>>>> wrote: > >>>> > >>>>> let me know > >>>>> > >>>>> thank you > >>>>> > >>>>> —Z > >>>> > >>>> > >>>> > >>>> > >>>> -- > >>>> Ryan Blue > >>>> Software Engineer > >>>> Netflix > >>> > >> > > > > -- Ryan Blue Software Engineer Netflix
