[ 
https://issues.apache.org/jira/browse/AVRO-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223236#comment-15223236
 ] 

ASF GitHub Bot commented on AVRO-1819:
--------------------------------------

GitHub user DrVirtual opened a pull request:

    https://github.com/apache/avro/pull/83

    AVRO-1819 and AVRO-1820: Parsing aliases and custom properties of request's 
field

    AVRO-1819: Parsing aliases of request's field
    AVRO-1820: Parsing custom properties of request's field
    
    Fixed bug in org.apache.avro.Protocol.parseMessage of loss field's aliases 
and custom properties.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrVirtual/avro 
AVRO-1819_AVRO-1820_Request_field_properties

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #83
    
----
commit eb5c5ab3fb7bc25f78ff0f7215a302658532c744
Author: k.usachev <[email protected]>
Date:   2016-04-03T11:43:07Z

    AVRO-1819: Parsing aliases of request's field
    AVRO-1820: Parsing custom properties of request's field

----


> org.apache.avro.Protocol.parseMessage doesn't respect request field's aliases
> -----------------------------------------------------------------------------
>
>                 Key: AVRO-1819
>                 URL: https://issues.apache.org/jira/browse/AVRO-1819
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.9.0
>            Reporter: Konstantin Usachev
>
> Avro specification (https://avro.apache.org/docs/1.8.0/spec.html#Aliases 
> "Named types and fields may have aliases") and Idl compiler supports aliases 
> on request's fields. But org.apache.avro.Protocol.parseMessage have a special 
> code to parse request body (not the same as for an ordinary record) and 
> during field parsing we don't keep info about aliases. So it leads to lack of 
> important functionality supporting protocol refactoring with backward 
> compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to