[ 
https://issues.apache.org/jira/browse/AVRO-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266942#comment-15266942
 ] 

Ryan Blue commented on AVRO-1838:
---------------------------------

I agree about not worrying about the redundant modifier.

Why does the current patch introduce a new maven module? Can't all of the Java 
code inherit from the lang/java/pom.xml? I don't see a compelling reason to 
move everything, but I'm not sure what your reasoning was.

> Ensure Checkstyle enforces trailing spaces rule
> -----------------------------------------------
>
>                 Key: AVRO-1838
>                 URL: https://issues.apache.org/jira/browse/AVRO-1838
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.8.0
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>              Labels: checkstyle
>             Fix For: 1.8.1
>
>         Attachments: AVRO-1838-20160502-BuildFails.patch, 
> AVRO-1838-20160502-disable-RedundantModifier.patch
>
>
> Followup of AVRO-1828
> We want to make sure the code stays as clean as possible by ensuring that 
> Checkstyle fails the build if they are present.
> The checkstyle maven module describes how to do this in a multi module 
> project (like avro):
> https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/multi-module-config.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to