[
https://issues.apache.org/jira/browse/AVRO-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392714#comment-15392714
]
ASF GitHub Bot commented on AVRO-1882:
--------------------------------------
GitHub user sachingsachin opened a pull request:
https://github.com/apache/avro/pull/113
AVRO-1882: ConcurrentHashMap with non-string keys fails in Java 1.8
Also updating maven-shade-plugin as per [this
thread](http://search-hadoop.com/m/F2svI1oJXGf1htLgb&subj=Re+Unable+to+build+clean+checkout+of+avro+from+master)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sachingsachin/avro AVRO_1882
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/113.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #113
----
commit faf46e81434adfd4b37844de67c01b39ab478ba2
Author: Sachin Goyal <[email protected]>
Date: 2016-07-25T21:32:46Z
AVRO-1882: ConcurrentHashMap with non-string keys fails in Java 1.8
----
> ConcurrentHashMap with non-string keys fails in Java 1.8
> --------------------------------------------------------
>
> Key: AVRO-1882
> URL: https://issues.apache.org/jira/browse/AVRO-1882
> Project: Avro
> Issue Type: Bug
> Affects Versions: 1.8.1
> Reporter: Sachin Goyal
> Fix For: 1.8.2
>
> Attachments: TestNonStringConcurrentMap.java
>
>
> Support for ConcurrentHashMaps with non-string keys seems to be broken when
> 1.8 version of Java is used because the newer ConcurrentHashMap uses the
> names "key" and "val" instead of "key" and "values" for its Map.Entry class.
> [HashEntry in
> 1.7|http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/util/concurrent/ConcurrentHashMap.java#218]
> [MapEntry in
> 1.8|http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/8u40-b25/java/util/concurrent/ConcurrentHashMap.java?av=h#3468]
> Hence avro-code that assumes the presence of key/value breaks.
> ([ReflectData.java:L434-L443|https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/reflect/ReflectData.java#L434-L443])
> Run the attached test to see the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
