[ 
https://issues.apache.org/jira/browse/AVRO-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396119#comment-15396119
 ] 

Andrius Druzinis-Vitkus commented on AVRO-607:
----------------------------------------------

The size went up from 852 KB to 1 MB. Is this an acceptable increase? 

These added classes would potentially benefit a few other bits throughout the 
codebase where a map is used instead of a cache. 

> SpecificData.getSchema not thread-safe
> --------------------------------------
>
>                 Key: AVRO-607
>                 URL: https://issues.apache.org/jira/browse/AVRO-607
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.3.3, 1.8.1
>            Reporter: Stephen Tu
>            Assignee: Andrius Druzinis-Vitkus
>            Priority: Blocker
>              Labels: newbie, patch
>             Fix For: 1.8.2
>
>         Attachments: AVRO-607.patch, AVRO-607.patch
>
>
> SpecificData.getSchema uses a WeakHashMap to cache schemas, but WeakHashMap 
> is not thread-safe, and the method itself is not synchronized. Seems like 
> this could lead to the data structure getting corrupted. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to