If we have files that fail to include the required ASF licensing headers, you're correct that's important to fix.
I think either working on it before or after would be fine. Ideally, Yetus Precommit should properly let us know when a patch is fixing those kinds of problems, so it would be a good validation that things are working. On Thu, Aug 18, 2016 at 8:18 PM, suraj acharya <[email protected]> wrote: > Okay. I will look at the docker command and the image. > > One other question I have is that the asflicense is an important aspect of > yetus. However, many java files have that missing. And whenever a patch > touches that file it returns a -1. Do you think I should first fix all the > licenses and then continue with this? > > S > > -Suraj Acharya > > On Thu, Aug 18, 2016 at 12:37 PM, Sean Busbey <[email protected]> wrote: > >> is the 3-5 minutes doing the tests across all of the language >> libraries or just the java ones? >> >> docker will definitely be needed, due to the number of different >> system dependencies needed to build the different languages. >> I was hoping we could reuse the Docker image that is currently >> used for the "./build.sh docker" command. >> >> >> On Wed, Aug 17, 2016 at 6:41 PM, suraj acharya <[email protected]> >> wrote: >> > Hi, >> > I am a new guy and I have been working on setting up pre-commit check for >> > Avro : AVRO-1887 <https://issues.apache.org/jira/browse/AVRO-1887>. >> > >> > I was looking at the unit tests being run currently. It takes somewhere >> > around 3-5 minutes depending on the network and the repo's present. >> > I was thinking that since the time is so low why not run all the tests >> for >> > every commit. Also, the tests being lightweight I was thinking that there >> > is no need for docker to be needed. >> > >> > I would like to gather your opinions on this topic before going further >> > down this path. >> > >> > Thanks >> > >> > -Suraj Acharya >> >> >> >> -- >> busbey >> -- busbey
