[ 
https://issues.apache.org/jira/browse/AVRO-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15463574#comment-15463574
 ] 

ASF GitHub Bot commented on AVRO-1908:
--------------------------------------

GitHub user rdblue opened a pull request:

    https://github.com/apache/avro/pull/117

    AVRO-1908: Fix TestSpecificCompiler reference to private method.

    AVRO-1884 changed makePath to a private method from a package-private
    static method. This broke the test that references the method in IPC.
    The fix is to make the instance method package-private and update the
    test to use an instance of SpecificCompiler.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rdblue/avro AVRO-1908-fix-build-after-1884

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #117
    
----
commit 42cc964207170ab71ab306429ecea642e54048a0
Author: Ryan Blue <[email protected]>
Date:   2016-09-04T21:54:40Z

    AVRO-1908: Fix TestSpecificCompiler reference to private method.
    
    AVRO-1884 changed makePath to a private method from a package-private
    static method. This broke the test that references the method in IPC.
    The fix is to make the instance method package-private and update the
    test to use an instance of SpecificCompiler.

----


> IPC TestSpecificCompiler build is broken
> ----------------------------------------
>
>                 Key: AVRO-1908
>                 URL: https://issues.apache.org/jira/browse/AVRO-1908
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>            Reporter: Ryan Blue
>
> AVRO-1884 changed {{SpecificCompiler.makePath}} to {{private 
> SpecificCompiler#makePath}}, which broke building the tests in the IPC 
> package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to