[ 
https://issues.apache.org/jira/browse/AVRO-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15498379#comment-15498379
 ] 

ASF GitHub Bot commented on AVRO-90:
------------------------------------

GitHub user sugatamazumdar opened a pull request:

    https://github.com/apache/avro/pull/126

    Avro Trial for Bug with Unions AVRO-90

    Avro Trial for Bug with Unions AVRO-90.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zolyfarkas/avro trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/avro/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #126
    
----
commit 938dae2b05bafa3cfde98e5a22c0534a5ca85c70
Author: unknown <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-08-28T22:04:13Z

    apply logicaltype patch and change version

commit b05ecf429f19e0f4491cc4bcd3152b120bbac121
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-02T22:28:55Z

    [fix] AVRO-1575

commit fcfd7174d9de2d85a2e85ad23b1b12f894035fcb
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-03T19:45:59Z

    [fix] AVRO-1580

commit c0ac4c95da970c013f309ac6c1dd2dbfc8a48b56
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-04T14:10:01Z

    Merge origin/trunk into trunk
    
    Conflicts:
        lang/java/archetypes/avro-service-archetype/pom.xml
        lang/java/archetypes/pom.xml
        lang/java/avro/pom.xml
        lang/java/compiler/pom.xml
        lang/java/ipc/pom.xml
        lang/java/mapred/pom.xml
        lang/java/maven-plugin/pom.xml
        lang/java/pom.xml
        lang/java/protobuf/pom.xml
        lang/java/thrift/pom.xml
        lang/java/tools/pom.xml
        lang/java/trevni/avro/pom.xml
        lang/java/trevni/core/pom.xml
        lang/java/trevni/doc/pom.xml
        lang/java/trevni/pom.xml
        pom.xml

commit ca14747273aade4a69fa5ed8955fb0aa3115aa8d
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-08T17:03:02Z

    [AVRO-1497] logicalType implementation complete.

commit ce874bd46e1572b4c548e5a399114560eff19753
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-08T18:25:49Z

    [AVRO-1577] resources need to be closed properly

commit 8f4759d86c0f09addc972703ce4accf452478207
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-08T19:51:32Z

    [AVRO-1582] serialize nullable json fields better

commit 76256c80b033edd2a2946435d1f6bcfbf9ed741d
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-08T19:55:36Z

    [AVRO-1582] serialize nullable json fields better

commit 8975c785bbca74765d1be0839b34c76e9a5dccf5
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-08T20:45:54Z

    [AVRO-1497] minor cleanup

commit 9c1279f4f1369eaade35d133f7d5622d1a461811
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-08T21:23:52Z

    [AVRO-1497] formatting cleanup

commit a8925e52481f93e7209c9b7fb5b4a671a6ca2f02
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-09T20:48:42Z

    [AVRO-1497] logicalType Joda date extra serialization

commit 5a0c00d218a0f2f6178eb9e772b6ff4da9e49479
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-10T21:36:39Z

    [AVRO-1497] logicalType extra serialization tests for schema compatibility

commit 03db3818349c5e13203b95ebaa0b71beda8d451c
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-09-11T20:16:23Z

    [AVRO-1497] fix joda version

commit b607e80e6197c8ad36af8bdea8d4d2daafdacc84
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-02T21:28:33Z

    [AVRO-1497] fix joda version

commit 329e9ea1faf2604f11180292f427a96cc2e7a19c
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-04T00:46:11Z

    [AVRO-1497] fix Generic Data Deep Copy

commit d6c6ca4a1a9d5cfe46d6cb2775410a2e03ed82f2
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-04T01:49:40Z

    [DEFAULTING JSON] supporting change

commit ad19fc22520d5f8289d027a0e32aa35779e8be87
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-08T01:43:34Z

    [DEFAULTING JSON] supporting change

commit 75237483bff9610963b91036ec6acfb4e6bbc461
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-09T00:22:12Z

    [DEFAULTING JSON] supporting change

commit 0c121ea95281861c249b886734ba6427fcdc788f
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-14T20:15:44Z

    [PIMCO FORK] add distribution management to support deployment to 
artifactory.

commit f1bd9f113ccc279701b2673d11effc5da491beae
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-15T17:36:38Z

    [PIMCO FORK] add PIMCO scm data

commit 024ce0eea56366651290e8760e1964d912b59607
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-15T19:24:32Z

    [PIMCO FORK] use later release plugin

commit 9e9247a80b644adc70216d3defccf8cf7a4126dd
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-15T21:37:34Z

    [PIMCO FORK] disable unit tests because the release plugin still wants to 
run them for whatever reason...

commit 0a23da1b2c0467bfcfb98798e10376a750a1d42e
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-16T14:10:46Z

    [PIMCO FORK] disable javadoc generation, too expensive and of limited use,

commit a9955d630c269349e87787e2d9c24ad0c0e6adb1
Author: NULL NULL <svc_core...@devpmapp1.pimco.imswest.sscims.com>
Date:   2014-10-16T19:17:44Z

    [maven-release-plugin] prepare release avro-toplevel-1.8.0.p

commit 923643381d6fdd104fb945eb7bdaa43f2e49618b
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-16T20:00:13Z

    [PIMCO FORK] change versions

commit 09dd0312c04ba0c4273abb01d2dae040a217a484
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-16T20:07:31Z

    [PIMCO FORK] change versions

commit ef5769375a78aaf5bd971affcf537e32584c31b9
Author: admin <svc_core...@devpmapp1.pimco.imswest.sscims.com>
Date:   2014-10-16T20:50:29Z

    [maven-release-plugin] prepare release avro-toplevel-1.8.0.0.p

commit 671a08bb63575064d897085c749c03222f767198
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-16T21:21:52Z

    [PIMCO FORK] change versions

commit bd6f74f1a685d92fd599a1da2379c3313837c3da
Author: admin <svc_core...@devpmapp1.pimco.imswest.sscims.com>
Date:   2014-10-16T21:33:05Z

    [maven-release-plugin] prepare release avro-toplevel-1.8.0.1.p

commit dbf4ae124a278c9114dccacf7c14323fc7dbc4a9
Author: zfarkas <zfar...@mez-rdp-608.pimco.imswest.sscims.com>
Date:   2014-10-17T15:34:23Z

    [PIMCO FORK] change versions

----


> json encoding does not encode unions correctly
> ----------------------------------------------
>
>                 Key: AVRO-90
>                 URL: https://issues.apache.org/jira/browse/AVRO-90
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.1.0
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 1.1.0
>
>         Attachments: AVRO-90.patch
>
>
> The Json encoding implemented in Java does not encode unions as intended.  In 
> particular:
>   - branches are labeled with their Java type enum name (all caps) rather 
> than their Json type name (lowercase)
>   - branches for named types (records, enums, fixed) are labeled with the 
> type rather than the name
>   - nulls are labelled -- a null value for a union should be untagged



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to